#!/usr/bin/env bash
s="a-b-c"
# doubling the slash replaces every match
echo "${s//-/_}"

${s//old/new} replaces every occurrence